Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

> Don’t force push after review, until the review is complete. This keeps the history of the review process but you can later merge the fixups with the commits they logically belong in right before merging.

I've had to talk to soooo many developers about this. I want to see what changed since my last review, not restart my review.



When I force push to a branch on GitLab with an open merge request, GitLab retains the previous set of commits, and provides an interface within the merge request to compare the current set of commits to previous sets. I love this feature.


`git range-diff` can be handy for the reviewer when trying to "recover from" a mid-review force-push.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: